Conversation
- close() during CONNECTING now fails the connection instead of opening first - Constructor rejects URLs with credentials (username/password) - Subprotocol dedup uses case-sensitive comparison per RFC 7936
- Better specs with named params for handler callbacks - Document :global choice with rationale comment - Extract shared websocket lifecycle into Server macro - Use struct update consistently (no Map.put for struct keys) - Consolidate dialyzer suppression to single module-level attr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mint-backed WebSocket client for QuickBEAM runtimes and contexts.
Backend — adds
QuickBEAM.WebSocketon top ofMint.HTTP+Mint.WebSocket:__ws_connect__ws_send__ws_closeJS WebSocket API — updates the browser polyfill to match expected platform behavior:
ws:/wss:plushttp:/https:normalizationbinaryTypehandling forBlobandArrayBufferbufferedAmounttrackingRuntime integration — wires WebSockets into both:
QuickBEAM.RuntimeQuickBEAM.ContextWPT coverage — ports constructor / protocol / close / binary send cases plus context integration:
test/wpt/wpt_websocket_test.exsDocs
README.mddocs/javascript-api.mddocs/architecture.mdAlso fixes swallowed QuickJS module-evaluation job errors so
QuickBEAM.load_module/3returns top-level module exceptions correctly.Verified with:
mix test test/wpt/wpt_websocket_test.exsQUICKBEAM_BUILD=1 mix test